[m-rev.] for review: Modify code for stricter mode checking.

Julien Fischer jfischer at opturion.com
Mon Aug 25 16:36:17 AEST 2014

On Mon, 18 Aug 2014, Peter Wang wrote:

> The following changes are necessary to compile the code following an
> upcoming change to the mode checker.  Some of them are mode errors.
> browser/declarative_oracle.m:
> 	The result of `query_oracle_kb' should be specific
> 	to avoid mode errors in callers.
> compiler/accumulator.m:
> 	Help the compiler infer the declared inst.
> compiler/mode_robdd.tfeirn.m:
> 	`zero' must be declared to return a normalised tfeirn value to
> 	avoid mode errors.  Change `one' for symmetry.
> 	`var_restrict_true' and `var_restrict_false' may return
> 	unnormalised tfeirn values (judging by the code).
> 	Modify `normalise' to help the compiler infer
> 	the declared inst.
> compiler/tupling.m:
> deep_profiler/autopar_find_best_par.m:
> 	Delete final insts that the compiler cannot verify.
> library/tree234.m:
> 	Help the mode checker out using an explicit switch.
> tests/hard_coded/bitmap_test.m:
> tests/hard_coded/bitmap_tester.m:
> 	Add missing modes.

That looks fine.


More information about the reviews mailing list