[m-rev.] for review: Fix --link-object <archive> with --restricted-command-line.

Julien Fischer jfischer at opturion.com
Wed Aug 6 14:15:41 AEST 2014

On Wed, 6 Aug 2014, Peter Wang wrote:

> On Wed, 6 Aug 2014 12:58:35 +1000 (EST), Julien Fischer <jfischer at opturion.com> wrote:
>> Hi Peter,
>> On Wed, 6 Aug 2014, Peter Wang wrote:
>>> Branches: master, 14.01
>>> When --restricted-command-line is enabled, we try to shorten the link
>>> command by creating a temporary archive of object files, including files
>>> specified with --link-object.  --link-object can also be used to specify
>>> archives (.a) to link with,
>> The documentation for --link-object says nothing about using it with
>> archives, although the first example of its use in the user's guide is
>> with an archive.
>> If it is intended that --link-object be used with archives, then I think
>> the documentation should explicitly say that.
> Yes, I think it should be allowed as it's been around and in use for a
> while.
> Here is a patch for review.
> Peter
> ---
> It was not explicitly stated that --link-object and MLOBJS may specify
> archives to link with.  The Mercury build system uses that fact, the

What the Mercury build system does and what should be recommended to
users are often two very different things ;-)

> documentation contains some examples doing so, and it has been a
> consideration since at least commit eadcd7ab00ca5599f4bc371803afd5b106c581f6,
> so document it as a supported feature.
> compiler/options.m:
> doc/reference_manual.texi:
> doc/user_guide.texi:
> 	Mention archives in --link-object and MLOBJS documentation.

That looks fine.


More information about the reviews mailing list