[m-rev.] for review 1/2: Add test cases for bug300
paul at bone.id.au
Mon Oct 7 12:18:36 AEDT 2013
On Mon, Oct 07, 2013 at 11:53:39AM +1100, Julien Fischer wrote:
> On Wed, 2 Oct 2013, Paul Bone wrote:
>> Add test cases for bug300
> I find it inconvenient that this diff is separate from the one that
> actually fixes the bug.
It makes more sense to me, they're seperate changes that happen to be
related. Especially that this patch preceeds the fix.
>> Add simple test case
>> Run the new test case with --optimize-constructor-last-call
>> This test case can detect the bug in C grades, where as the test case in
>> tests/valid/bug300.m only works in Java grades.
> Presumably, this one also triggers the bug in Java grades? If so, why
> do we need two test cases?
I assume so. I include both because I wrote the other one first and didn't
see any point removing it after I added this one.
>> Setup MCFLAGS so that the test case can detect the bug.
> You should also mention that the bug has been fixed in the NEWS file for
Okay, that's relevant to the other patch.
More information about the reviews