[m-rev.] for review: Provide a helpful error if no C sharp compiler could be found

Paul Bone paul at bone.id.au
Thu May 23 23:09:30 AEST 2013


On Thu, May 23, 2013 at 10:57:14PM +1000, Julien Fischer wrote:
> On Thu, May 23, 2013 at 10:39 PM, Paul Bone <paul at bone.id.au> wrote:
> 
> > On Thu, May 23, 2013 at 10:12:19PM +1000, Julien Fischer wrote:
> > > On Thu, May 23, 2013 at 8:48 PM, Paul Bone <paul at bone.id.au> wrote:
> >
> > > > --- a/m4/mercury.m4
> > > > +++ b/m4/mercury.m4
> > > > @@ -369,6 +369,13 @@ EOF
> > > >      esac
> > > >  done
> > > >
> > > > +# If the user specified one or more compilers and we couldn't find any
> > > > +# then abort configuration.
> > > > +if test "$mercury_cv_with_csharp_compiler" != "" -a "$CSC" = ""; then
> > > > +    AC_MSG_ERROR([No C sharp compilers could be found.]
> > >
> > >
> > > How about:
> > >
> > >     No working C# compiler could be found.
> >
> > s/working/suitable/  Since a C# compiler might work but not support
> > generics.
> 
> 
> Fine, although didn't your change add a separate test for whether generics
> are supported?
> 

Yes, which is why this case can be triggered if there is a compiler that
works, but isn't suitable.  It would be incorrect to say that the compiler
doesn't work, mearly that it isn't suitable.


-- 
Paul Bone
http://www.bone.id.au



More information about the reviews mailing list