[m-rev.] [for review] Fix some styling of the menu.

Peter Wang novalazy at gmail.com
Fri Apr 19 10:45:58 AEST 2013

On Thu, 18 Apr 2013 23:23:44 +1000, Paul Bone <paul at bone.id.au> wrote:
> For review by Peter.
> Fix some styling of the menu.
> I've had some feedback that the sub menu options don't look/feel like menu
> options, the user said that he didn't realize they were clickable.

I don't understand that, but okay.

> To try
> to fix this I've painted them the same colour as the menu options (this
> provide better contrast for my testes too)


> and made the font size the same.
> I've also added 5px of padding on all sides of each submenu's text and
> enabled the same hover behaviour as the main menu options.  The latter two
> changes I think help the most to show that they're clickable.
> My personal testes are that grey on white is horrible.  It provides very
> little contrast and I wish that companies such as Google and Apple wouldn't
> do it.  And I'd rather we didn't either.

It looks okay, but I don't like how the hover background extends past
the hr.  How about removing the hr and enlarging the padding between
menu items to compensate?


diff --git a/css/common.css b/css/common.css
index 2d59e66..67ea801 100644
--- a/css/common.css
+++ b/css/common.css
@@ -131,7 +131,7 @@ font-size: 16px;
 background: none;
 border: none;
 font-family: georgia;
-padding: 5px;
+padding: 7px;
 ul.submenu li a:link, ul.submenu li a:visited{
@@ -148,6 +148,7 @@ font-style: italic;
 ul.submenu hr{
 color: white;
 margin: 6px 20px 6px 0px;

More information about the reviews mailing list