[m-rev.] for review: setting the reserve stack size on Windows
paul at bone.id.au
Wed Apr 10 14:23:30 AEST 2013
On Wed, Apr 10, 2013 at 01:36:28PM +1000, Julien Fischer wrote:
> For review by anyone.
> Add an option for controlling the C stack size on Windows.
> Add a new option, --cstack-reserve-size, that specifies the amount of virtual
> memory that should be reserved for the stack in executables on Windows systems.
> This is useful for non-trivial programs that use the high-level C backend since
> they often bump into the default 1Mb limit.
> Add the new option.
> Pass the appropriate flags to the linker if the new option is given.
> Announce the new option.
I see that we don't override the default. This means that a such a program
will crash anyway, and the user still has to go and find this option. I
think that it is reasonable to also increase the default C stack size so that
it is less likely that a user will have this error. The default value should
also appear in the help message and users' guide.
You did not mention the changes to the users guide in the summary.
More information about the reviews