[m-rev.] diff: Fix feedback test case failures in nightly builds.

Peter Wang novalazy at gmail.com
Thu Jan 12 17:23:50 AEDT 2012


On Mon, 9 Jan 2012 11:47:16 +1100, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
> 
> The feedback tests on goliath were failing.  The problem is that the test suite
> is run without first building the workspace and the mdprof_create_feedback and
> mdprof_report_feedback tools are not available.
> 
> tests/feedback/Mmakefile:
>     Fix the test case failure by using the mdprof feedback tools in PATH if the
>     workspace has not been built.
> 
> Index: tests/feedback/Mmakefile
> ===================================================================
> RCS file: /home/mercury1/repository/tests/feedback/Mmakefile,v
> retrieving revision 1.1
> diff -u -p -b -r1.1 Mmakefile
> --- tests/feedback/Mmakefile	5 Dec 2011 05:58:05 -0000	1.1
> +++ tests/feedback/Mmakefile	6 Jan 2012 12:51:45 -0000
> @@ -14,8 +14,24 @@ TESTS_DIR = ..
>  SUBDIRS=
>  include $(TESTS_DIR)/Mmake.common
>  
> -FB_CREATE = ../../deep_profiler/mdprof_create_feedback
> -FB_REPORT = ../../deep_profiler/mdprof_report_feedback
> +# Try to use the feedback tools in this workspace if available, Otherwise use
> +# the feedback tools in PATH
> +FB_CREATE_WS = ../../deep_profiler/mdprof_create_feedback
> +FB_REPORT_WS = ../../deep_profiler/mdprof_report_feedback

I believe this should take WORKSPACE into account, or whatever it takes
to use the tools from stage2.

Peter
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list