[m-rev.] For review: Thread pinning improvements.

Julien Fischer juliensf at csse.unimelb.edu.au
Wed Oct 26 02:11:35 AEDT 2011


On Sat, 22 Oct 2011, Julien Fischer wrote:

>
> On Wed, 5 Oct 2011, Paul Bone wrote:
>
>> 
>> configure.in:
>> Mmake.common.in:
>>    Detect presence of the hwloc library.
>
> ...
>
>> Index: configure.in
>> ===================================================================
>> RCS file: /home/mercury1/repository/mercury/configure.in,v
>> retrieving revision 1.596
>> diff -u -p -b -r1.596 configure.in
>> --- configure.in	4 Oct 2011 02:37:57 -0000	1.596
>> +++ configure.in	4 Oct 2011 14:31:39 -0000
>> @@ -1265,7 +1265,7 @@ mercury_check_for_functions \
>>         grantpt unlockpt ptsname tcgetattr tcsetattr ioctl \
>>         access sleep opendir readdir closedir mkdir symlink readlink \
>>         gettimeofday setenv putenv _putenv posix_spawn sched_setaffinity \
>> -        sched_getcpu sched_yield mkstemp
>> +        sched_getaffinity sched_getcpu sched_yield mkstemp
>> 
>> #-----------------------------------------------------------------------------#
>> 
>> @@ -5107,6 +5107,30 @@ MERCURY_CHECK_READLINE
>> 
>> #-----------------------------------------------------------------------------#
>> #
>> +# Check for libhwloc, http://www.open-mpi.org/projects/hwloc/
>> +#
>> +PKG_PROG_PKG_CONFIG
>
> The above macro will abort if pkg-config is not available on the system.
> This dependency is not documented anywhere but in any case it needs to be
> removed since we build on systems where it isn't available.

Furthermore, since this change was committed the nightly builds on eris
have been broken:

+ namespace_opt=
+ case "$HOST" in
+ namespace_opt=--no-check-namespace
+ aclocal
acinclude.m4:14: warning: underquoted definition of
MERCURY_CHECK_FOR_HEADERS
acinclude.m4:14:   run info '(automake)Extending aclocal'
acinclude.m4:14:   or see
http://sources.redhat.com/automake/automake.html#Extending-aclocal
+ autoconf
configure.in:1345: error: possibly undefined macro: AC_DEFINE
       If this token and others are legitimate, please use
m4_pattern_allow.
       See the Autoconf documentation.
+ false
+ exit 1
+ exit_status=1
+ rm -f
/Users/mercury/mercury/public/test_mercury/test_dirs/eris/lockfile
+ exit 1

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list