[m-rev.] diff: Fix bug #233

Paul Bone pbone at csse.unimelb.edu.au
Fri Nov 25 01:02:30 AEDT 2011


On Fri, Nov 25, 2011 at 12:49:10AM +1100, Julien Fischer wrote:
> 
> 
> On Thu, 24 Nov 2011, Paul Bone wrote:
> 
> >Fix an error where the runtime system aborted with "sem_post: Invalid
> >argument".
> >
> >runtime/mercury_context.c:
> >   The error message as important, since sem_timedwait actually raised the
> >   error.  When this occurred the error was incorrectly reported as being
> >   raised by the sem_post syscall.
> >
> >   Use >= rather than > when testing if the nanoseconds field of a timeval
> >   structure for sem_timedwait should overflow into the seconds field.
> 
> Does this also need to go on to the release branch?
> 

That's up to you (as release manager), if you think it's a serious enough bug
or the parallel low-level C grades are important enough.  I've made this
seperate to my other patches in case you want to apply it to the release
branch.

It may not apply cleanly, if it doesn't (becase sem_timedwait is not used) then
the bug doesn't exist on the release branch.

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20111125/81e643f6/attachment.sig>


More information about the reviews mailing list