[m-rev.] for post-commit review: configure.in enhancements

[Paul Bone]

On Thu, May 26, 2011 at 06:13:58PM +1000, Zoltan Somogyi wrote:
> +
> +min_minutes_per_grade=10
> +max_minutes_per_grade=30
> +min_minutes=`expr $num_installed_grades \* $min_minutes_per_grade`
> +max_minutes=`expr $num_installed_grades \* $max_minutes_per_grade`
> +min_hours=`expr '(' $min_minutes + 30 ')' / 60`
> +max_hours=`expr '(' $max_minutes + 30 ')' / 60`
> +MERCURY_MSG("Configuring to install $num_installed_grades grades.")
> +if test $max_minutes -gt 2 -a $min_minutes -ne $max_minutes

Should this test be done on $max_hours and $min_hours instead?

> +then
> +    MERCURY_MSG("This will likely take $min_hours to $max_hours hours.")
> +else
> +    MERCURY_MSG("This will likely take $min_minutes to $max_minutes minutes.")
> +fi
> +# This message would be easier to read with some parentheses or commas,
> +# but getting m4 to accept either seems to be impossible.
> +MERCURY_MSG("You can make the install faster by installing fewer grades")
> +MERCURY_MSG("as shown by the fine-tuning section of the INSTALL file or by")
> +MERCURY_MSG("compiling the files of each grade in parallel which you can do")
> +MERCURY_MSG("via a command such as make install -j2.")
> +
>  case "$remake_dependencies.$reconfiguring" in
>      "true.no")
>          MERCURY_MSG("regenerating dependencies to enable GCC backend.")
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20110527/5703e413/attachment.sig>