[m-rev.] for review: fix a comment

Julien Fischer juliensf at csse.unimelb.edu.au
Tue May 3 22:39:18 AEST 2011


On Tue, 3 May 2011, Ian MacLarty wrote:

> On Mon, May 02, 2011 at 12:23:49PM +1000, Julien Fischer wrote:
>>
>> On Thu, 28 Apr 2011, Ian MacLarty wrote:
>>
>>> For review by anyone.
>>>
>>> Branches: main
>>>
>>> Change the comment describing the behaviour of parsing_utils.separated_list to
>>> match its actual behaviour.
>>>
>>> I didn't change the behaviour to match the comment, because the test case
>>> already tests that the predicate fails for empty sequences,
>>
>> That behaviour seems odd - I suspect the test case is wrong.
>>
>
> Ok I agree.  Here's a new diff:
>
> Branches: main
>
> Change the behaviour of parsing_utils.separated_list to return an
> empty list instead of failing if its ho argument doesn't match
> any input, as documented in the comments.
>
> library/parsing_utils.m:
>    As above.
>
> tests/general/test_parsing_utils.exp:
> tests/general/test_parsing_utils.m:
>    Expect empty lists from separated_list and comma_separated_list.

That's fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list