[m-rev.] For review: Move some goal path/id related code into mdbcomp

Paul Bone pbone at csse.unimelb.edu.au
Thu Jan 13 11:38:20 AEDT 2011


On Thu, Jan 13, 2011 at 02:49:11AM +1100, Zoltan Somogyi wrote:
> On 12-Jan-2011, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
> > For review just incase anyone has a reason why this is bad as it creates a new
> > file in CVS which can't be undone nicely.
> 
> Creating the file is ok.

Thanks, committed.

> > mdbcomp/goal_rep.m is not part of the diff, it is included below the diff in
> > this e-mail.
> 
> Why isn't it in the diff? Afetr doing a "cvs add" on the file, it SHOULD show
> up in a diff. If it does not, you may have forgotten to do the "cvs add", which
> would break the repository for everyone else when the diff is committed.
> 

I didn't 'cvs add' yet because I didn't want to commit to this file name (or
the change without some (informal) review.  I can't remember if 'cvs add'
modifies the repository or just the local copy.

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20110113/bf6453fe/attachment.sig>


More information about the reviews mailing list