[m-rev.] For post-commit review: Correct problems in the automatic parallelism analysis.

[Paul Bone]

On Thu, Oct 07, 2010 at 02:40:41PM +1100, Julien Fischer wrote:
> 
> On Thu, 7 Oct 2010, Paul Bone wrote:
> 
> >Anyone may review the changes to the standard library and news file.
> >
> >Thanks.
> >
> >---
> 
> >library/lazy.m:
> >   Moved lazy.m from extras to the standard library.
> 
> Did you delete the copy in extras?

I'll fix it with a new commit.

> >library/Mercury.options:
> >   Add a work around for compiling lazy.m with intermodule optimisations.
> 
> The problem and workaround below have nothing to do with intermodule optimisation.

They where triggered during the intermodule pass and didn't occur when I had
lazy.m in the deep_profiler directory which doesn't do intermodule
optimisations.  Is termination a prerequsite of intermodule analysis?

> >Index: NEWS
> >===================================================================
> >RCS file: /home/mercury1/repository/mercury/NEWS,v
> >retrieving revision 1.535
> >diff -u -p -b -r1.535 NEWS
> >--- NEWS	6 Oct 2010 04:01:31 -0000	1.535
> >+++ NEWS	7 Oct 2010 02:18:48 -0000
> >@@ -16,6 +16,13 @@ Changes to the Mercury standard library:
> >  to the predicates of the same name in the list module, but do the relevant
> >  operations on keys instead of entire list elements.
> >
> >+* We have added a new module, lazy,to the standard library.  It facilitates
> 
> s/lazy,to/lazy, to/
>
> >+  the construction of lazy data structures.
> 
> Also we haven't added it.  It's been shifted from the extras distribution.
> I suggest changing this entry to something like:
> 
>     We have shifted the lazy evaluation module out of the extras
>     distribution and into a new standard library module called `lazy'.
> 

I agree, except: s/shifted/moved/

> >===================================================================
> >RCS file: /home/mercury1/repository/mercury/library/Mercury.options,v
> >retrieving revision 1.33
> >diff -u -p -b -r1.33 Mercury.options
> >--- library/Mercury.options	12 Jun 2009 05:00:26 -0000	1.33
> >+++ library/Mercury.options	6 Oct 2010 23:43:20 -0000
> >@@ -89,3 +89,8 @@ MCFLAGS-thread.semaphore += --no-local-t
> >
> ># Work around a problem in the HiPE compiler (as of Erlang R11B5).
> >MCFLAGS-bitmap += --no-erlang-native-code
> >+
> >+# Work around a warning for termination analysis of the user defined equality
> >+# and comparison code for lazy values.
> >+MCFLAGS-lazy += --no-halt-at-warn
> 
> --no-warn-non-term-special-preds would be a more appropriate option to
> use rather than disabling all warnings.
> 

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20101007/329a0e9f/attachment.sig>