[m-rev.] for review: improve support for folds over sets in stdlib

Peter Wang novalazy at gmail.com
Tue Nov 9 11:15:28 AEDT 2010

On 2010-11-08, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> For review by anyone.
> Support folds over sets with up to five accumulators in all the standard
> library modules that provide sets.
> Support mostly-unique and unique accumulators in set folds.
> (These were provided in some set modules, but not in others.)
> library/set.m:
> library/set_bbbtree.m:
> library/set_ctree234.m:
> library/set_ordlist.m:
> library/set_tree234.m:
> library/set_unordlist.m:
> 	Add predicates for fold over sets with up to five accumulators.
> 	As per the coding standard, where an operation has both a
> 	function version and a predicate version, the declaration for
> 	the function version should occur first in stdlib modules.

I wonder why that is.

> 	Fix up overlong lines.
> library/set_bbbtree.m:
> 	Add an XXX regarding the implementation of fold.
> library/list.m:
> 	Add additional modes to list.foldl3/8, list.foldl4/10,
> 	and list.foldl5/12 required by the above.
> 	Announce the changes.

The patch looks okay.

mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list