[m-rev.] For review: Make improvements to stack segments code.

Paul Bone pbone at csse.unimelb.edu.au
Mon Jun 7 23:07:49 AEST 2010

On Mon, Jun 07, 2010 at 10:53:45PM +1000, Julien Fischer wrote:
> On Mon, 7 Jun 2010, Paul Bone wrote:
>>    MR_construct_zone.
>>>>    error handlers.
>>>>    Do better locking on the free_memory_zones and used_memory_zones lists.
>>> Better locking in what sense?
>>    Updates to used_memory_zones now use a pthread mutex so that only one
>>    thread may be updating the list at once.  This lock is shared with the
>>    free_memory_zones structure.
> Just to be clear, the intent of my comment was that you should say as
> such in the log message.

Above is what I have changed the log message to.

>>> Please post a revised log message and diff once you have addressed the
>>> above.
>> Okay,  There also seem to be some problems with hlc.gc.par, so I'll address
>> those before I re-post it.
> You should also test in a trseg grade and probably one of the mmos
> grades.

What's mmos?  A search in doc/user_guide.texi gives me nothing.  Searching
runtime/mercury_grade.h tells me it means "Minimal Model Own Stacks".  I guess
I'd like a description of what it does.  I've seen minimal model code that
seems to have something to do with the managment of contexts and switching
between them but I don't know what it actually does.

I recall the term Minimal Model from Logic Programming class but don't remember
enough to know the definition.  My point is, this should be in
doc/user_guide.texi, but perhaps commented out.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 489 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20100607/2871b270/attachment.sig>

More information about the reviews mailing list