[m-rev.] For review: Fix the handling of $DESTDIR on Windows.

[Julien Fischer]

On Thu, 16 Dec 2010, Paul Bone wrote:

>
> Julien had some comments in person, this patch fixes them.  I've placed it for
> review since it's too easy to make mistakes when modifying the build system.
>
> ---
>
> Mmke.vars.in:
>    Modify the documentation that discuss how to override INSTALL_PATH

s/discuss/discusses/

>    to describe setting of $DESTDIR instead.
>
>    Don't add a slash before INSTALL_PATH if DESTDIR is empty since this
>    breaks installation on Windows.  (This change has already been made
>    in Mmake.common.in)
>
>    Set more FINAL_INSTALL_ variables to support the new code in
>    Mmakefile and bindist.Makefile.in.
>
> Mmake.common.in:
>    Improve the prose in a comment.
>
> Mmakefile:
> bindist/bindist.Makefile.in:
>    Update installation message.
>
>    Tell the user that their install is in $(DESTDIR) if applicable.
>
>    Use FINAL_INSTALL variables rather than INSTALL variables.

I don't think the changes to bindist.Makefile.in are correct - it's
not connected with mmake stuff.  INSTALL_PREFIX is set by the
bindist INSTALL script for that -- in any case why would you want
to use DESTDIR with the binary distribution?

The diff looks fine apart from the above.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------