[m-rev.] For post-commit review: Compatibility with Debian packaging.

Julien Fischer juliensf at csse.unimelb.edu.au
Wed Dec 15 02:19:56 AEDT 2010


On Tue, 14 Dec 2010, Paul Bone wrote:

> Index: Mmake.common.in
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/Mmake.common.in,v
> retrieving revision 1.99
> diff -u -p -b -r1.99 Mmake.common.in
> --- Mmake.common.in	8 Dec 2010 08:54:29 -0000	1.99
> +++ Mmake.common.in	14 Dec 2010 06:41:30 -0000
> @@ -118,7 +118,7 @@ SHARED_LIBS		= @SHARED_LIBS@
> # Set the installation prefix. This is done here as well as
> # in scripts/Mmake.vars to avoid accidentally overwriting an
> # existing installation when using an installed mmake.
> -INSTALL_PREFIX		= @prefix@
> +INSTALL_PREFIX          = $(DESTDIR)/@prefix@

This breaks installation on Windows, e.g. because INSTALL_PREFIX is set
to
 	$(DESTDIR)/c:/where/to/install

and /c:/where/to/install is not a valid path on Windows.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list