[m-rev.] diff: Increase HBLKSIZE in BoehmGC for parallel grades.

Paul Bone pbone at csse.unimelb.edu.au
Thu Dec 9 10:58:07 AEDT 2010


On Wed, Dec 08, 2010 at 04:17:38PM +1100, Julien Fischer wrote:
> On Wed, 8 Dec 2010, Paul Bone wrote:
> >Index: Mmake.common.in
> >===================================================================
> >RCS file: /home/mercury1/repository/mercury/Mmake.common.in,v
> >retrieving revision 1.97
> >diff -u -p -b -r1.97 Mmake.common.in
> >--- Mmake.common.in	10 Oct 2009 10:44:13 -0000	1.97
> >+++ Mmake.common.in	8 Dec 2010 03:50:43 -0000
> >@@ -150,7 +150,8 @@ BOEHM_CFLAGS = @ENABLE_BOEHM_LARGE_CONFI
> ># Additional options to pass to the C compiler when building Boehm-GC for
> ># threads.
> >BOEHM_CFLAGS_FOR_THREADS = @ENABLE_BOEHM_THREAD_LOCAL_ALLOC@ \
> >-	@ENABLE_BOEHM_PARALLEL_MARK@
> >+	@ENABLE_BOEHM_PARALLEL_MARK@ \
> >+	-DHBLKSIZE=32768 -DCPP_LOG_HBLKSIZE=15
> 
> I suggest adding a comment above that definition describing what
> HBLKSIZE and CPP_LOG_HBLKSIZE are.
> 

Fixed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 490 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20101209/1e8e7746/attachment.sig>


More information about the reviews mailing list