[m-rev.] for tryout and/or review: removing globals from the I/O state

Ian MacLarty maclarty at csse.unimelb.edu.au
Wed Oct 14 15:39:43 AEDT 2009

On Wed, Oct 14, 2009 at 1:29 PM, Zoltan Somogyi <zs at csse.unimelb.edu.au> wrote:
> I would like feedback on this diff mostly in the form of "mmc --make" users
> trying out a version of the compiler with this diff, which I have installed
> on goliath in /home/goliath/workspaces/zs/test_install/bin. mmc --make
> is the functionality that is probably most affected by this diff. The diff
> has passed bootchecks in several grades, but bootcheck's tests of mmc --make
> are not as tough as real life use. I would also appreciate reviews, but
> the diff is 54,000+ lines long, and most of it is very boring. It is also
> more than 2 Mb in size, above the mail system's size limit, so I put it
> in a file for any reviewers to look at: ~zs/tmp/DIFF.globals_iostate.
> The diff still contains ZZZs marking the spots that at one time or another
> I thought deserved a second look. I intend to remove these ZZZs before commit,
> since I think I later made sure they were handled correctly, but any reviewers
> will probably want to concentrate on those spots.
> I would like to commit this as soon as possible, since the size of the diff
> makes conflicts between it and any other change to the compiler quite likely.
> (I already had to resolve a few.) On the other hand, I don't want to commit
> a diff that breaks mmc --make for people. That means I would really appreciate
> prompt feedback.

I tried this change on one of the MC projects that use --make and it
worked fine.

mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list