[m-rev.] for review: add RSS feed to Mercury site

Paul Bone pbone at csse.unimelb.edu.au
Tue Feb 10 11:09:32 AEDT 2009


On Mon, Feb 09, 2009 at 05:07:56PM +1100, Ian MacLarty wrote:
> For review by anyone.
> 
> Estimated hours taken: 1
> 
> Add RSS feed to Mercury site.
> 
> Makefile:
> Makefile.common:
> 	Add rules to build and install the rss.xml file.
> 
> rss.php3:
> 	Build the RSS feed from the news database.
> 
> include/functions.inc:
> 	Add a function to format a news item as an RSS
> 	item.
> 
> include/index.inc:
> 	Add a link to the RSS feed from the home page.
> 
> news/newsdb.inc:
> 	Mention the new feature in the news.
> 
> Index: include/index.inc
> ===================================================================
> RCS file: /home/mercury1/repository/w3/include/index.inc,v
> retrieving revision 1.5
> diff -u -r1.5 index.inc
> --- include/index.inc	13 Nov 1998 04:21:47 -0000	1.5
> +++ include/index.inc	9 Feb 2009 05:58:50 -0000
> @@ -15,3 +15,7 @@
>  For older news items, see the
>  (<a href="<? echo $root ?>/news.html">complete news archive</a>).
>  
> +<p>
> +
> +News is also available as an RSS feed at
> +<a href=\"http://www.mercury.csse.unimelb.edu.au/rss.xml\">http://www.mercury.csse.unimelb.edu.au/rss.xml</a>.

This should be a relative link rather than an absolute link.  (this is
not always easy to do in an included file).

> Index: news/newsdb.inc
> ===================================================================
> RCS file: /home/mercury1/repository/w3/news/newsdb.inc,v
> retrieving revision 1.110
> diff -u -r1.110 newsdb.inc
> --- news/newsdb.inc	9 Feb 2009 03:51:49 -0000	1.110
> +++ news/newsdb.inc	9 Feb 2009 05:58:21 -0000
> @@ -22,6 +22,13 @@
>  
>  $newsdb = array(
>  
> +"9 February 2009" => array("RSS Feed",
> +"You can now receive Mercury news items via an RSS feed by subscribing
> +to the following URL: 
> +<a href=\"http://www.mercury.csse.unimelb.edu.au/rss.xml\">http://www.mercury.csse.unimelb.edu.au/rss.xml</a>
> +"
> +),
> +

And here.

Thanks.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mercurylang.org/archives/reviews/attachments/20090210/abf95bc7/attachment.sig>


More information about the reviews mailing list