[m-rev.] Check for overflow in string.base_string_to_int for base 10

Julien Fischer juliensf at csse.unimelb.edu.au
Mon Feb 2 16:49:59 AEDT 2009

On Mon, 2 Feb 2009, Ralph Becket wrote:

> Estimated hours taken: 0.5
> Branches: main
> Only check for overflow when converting strings to ints when the base is 10.
> Other number bases are assumed to denote bit patterns and no overflow test
> is employed.
> 	Mention the change.
> library/string.m:
> 	Amend accumulate_int to perform an overflow check on base 10 numbers.
> tests/general/Mmakefile:
> tests/general/test_string_to_int_overflow.m:
> tests/general/test_string_to_int_overflow.exp:
> 	Add a test case.

That's fine (although I suggest that you boostrap it on a 32-bit machine
-- jupiter or eris**) before committing.


** don't use swordfish as it doesn't have a recent Mercury compiler
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list