[m-rev.] For review: Implement support for threadscope profiling.

Zoltan Somogyi zs at csse.unimelb.edu.au
Fri Dec 4 10:13:35 AEDT 2009


> Some of this stuff might be applicable to grades that don't use parallel
> conjunction.

I hope so.

> I want to talk to Zoltan about making a new grade with this parallelism
> profiling stuff in it.

You will have to shout VERY LOUDLY :-(

For now, and until this stuff has been fully debugged and we have reasonable
confidence in its correctness (grounded in experience, not hope), I think
we don't need a new grade for it, at least not committed in the repository.

> Maybe it should be called par_prof and one can have
> asm_fast.gc.par and asm_fast.gc.par_prof.

I think we should use a more specific name than "prof" for this, but yes,
if we have a new grade component, that's roughly what it would look like.

> Mostly I want to discuss the pros
> and cons of this

I am sure you can have a heated discussion with the other inhabitants
of the Mercury room about this, in which they would raise pretty much every
point I would.

> and also learn how to create a new grade.

Step 1: have those heated discussions, and get people to agree that it is a
good idea to create a new grade component.

Step 2: have another heated discussion about what it should be called. For
example, "prof" is a bad idea in this case, since it is already overloaded.

Step 3: have a look at the comment at the top of runtime/mercury_grade.h,
look at how all the files listed there (and I do mean ALL) as well as
mercury_grade.h itself handle grades and grade components, and then do
what they do, adapted to the specific needs of the grade component
you are adding.

Step 4: test the hell out of every existing grade as well as the new one,
to make sure you haven't broken anything.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list