[m-rev.] for review: java I/O improvements, putback clarifications

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Aug 25 18:51:05 AEST 2009


On Tue, 25 Aug 2009, Peter Wang wrote:

> Only the documentation parts really require review.
>
> Branches: main
>
> library/io.m:
>        Document the effect of io.putback_byte on the stream position, based
>        on the behaviour of ungetc().
>
>        Document the effect of io.seek_binary_input on the pushback buffer.
>
>        Implement io.read_line_as_string and io.read_file_as_string
>        efficiently for Java.
>
>        Make the globals ML_next_stream_id and MR_io_exception in Java
>        thread-safe.
>
>        Make the type of ML_io_stream_db more specific in Java.
>
>        Use the FileChannel class unconditionally.  We no longer support
>        Java < 1.5 so we don't need to use reflection to access that class at
>        runtime.
>
>        Throw Mercury-catchable exceptions on Java I/O errors.
>
>        Add class qualification or `may_not_duplicate' attributes on
>        foreign_procs to prevent problems with intermodule optimisation.
>
> tests/hard_coded/Mmakefile:
> tests/hard_coded/stream_putback.data:
> tests/hard_coded/stream_putback.exp:
> tests/hard_coded/stream_putback.m:
> tests/hard_coded/stream_putback_binary.exp:
> tests/hard_coded/stream_putback_binary.m:
>        Add test cases for io.putback_char, io.putback_byte and seeking.

That looks okay.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list