[m-rev.] For postcommit review: Some fixing for RBMM

Quan Phan quan.phan at cs.kuleuven.be
Thu Apr 30 17:49:48 AEST 2009


Hi,

I've committed these small changes.

Regards,
Quan.
-------------- next part --------------
Estimated hours taken: 0.1
Branch: main

Fix two bugs in RBMM.

compiler/rbmm.region_instruction.m:
    Add remove instructions for regions reachable from void variables.
    
runtime/mercury_region.h:
    Add a missing variable declaration.
-------------- next part --------------
Index: compiler/rbmm.region_instruction.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/rbmm.region_instruction.m,v
retrieving revision 1.7
diff -u -r1.7 rbmm.region_instruction.m
--- compiler/rbmm.region_instruction.m	23 Apr 2009 10:00:24 -0000	1.7
+++ compiler/rbmm.region_instruction.m	29 Apr 2009 16:05:49 -0000
@@ -1,7 +1,7 @@
 %-----------------------------------------------------------------------------%
 % vim: ft=mercury ts=4 sw=4 et
 %-----------------------------------------------------------------------------%
-% Copyright (C) 2005-2007, 2009 The University of Melbourne.
+% Copyright (C) 2005-2007 The University of Melbourne.
 % This file may only be copied under the terms of the GNU General
 % Public License - see the file COPYING in the Mercury distribution.
 %-----------------------------------------------------------------------------%
@@ -289,6 +289,9 @@
     set.fold(record_instruction_after_prog_point(remove_region_instr,
             ProgPoint, CallerGraph),
         RemovedAfterProgPoint, !RegionInstructionProc),
+    set.fold(record_instruction_after_prog_point(remove_region_instr,
+            ProgPoint, CallerGraph),
+        DeadVoidVarRegions, !RegionInstructionProc),
 
     svmap.set(ProgPoint, set.union(BecomeDead, DeadVoidVarRegions),
         !BecomeDeadAfterProc),
Index: runtime/mercury_region.h
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/runtime/mercury_region.h,v
retrieving revision 1.13
diff -u -r1.13 mercury_region.h
--- runtime/mercury_region.h	27 Apr 2009 12:39:53 -0000	1.13
+++ runtime/mercury_region.h	29 Apr 2009 16:05:54 -0000
@@ -2,7 +2,7 @@
 ** vim: ts=4 sw=4 expandtab
 */
 /*
-** Copyright (C) 2007-2009 The University of Melbourne.
+** Copyright (C) 2007-2008 The University of Melbourne.
 ** This file may only be copied under the terms of the GNU Library General
 ** Public License - see the file COPYING.LIB in the Mercury distribution.
 */
@@ -547,6 +547,7 @@
             do {                                                            \
                 MR_RegionHeader             *region;                        \
                 MR_RegionSemiDisjProtect    *semi_disj_prot;                \
+                int                         incr;                           \
                                                                             \
                 semi_disj_prot =                                            \
                     (MR_RegionSemiDisjProtect *) (protection_block);        \


More information about the reviews mailing list