[m-rev.] for review: support --no-static-ground-terms in LLDS grades

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Jan 15 16:28:53 AEDT 2008

On Tue, 15 Jan 2008, Peter Wang wrote:

> Estimated hours taken: 2
> Branches: main
> Make the low-level code generator support the `--no-static-ground-terms'
> option.  Previously it was always enabled.

What are the reasons for this change?
I assume this is because static ground terms are not yet compatible with
structure reuse?)

> compiler/handle_options.m:
> 	Don't force `--static-ground-terms' to be enabled when using a
> 	low-level grade.
> compiler/var_locn.m:
> 	Add a type `may_use_static_ground_terms'.
> 	Make `var_locn_assign_cell_to_var' take an argument which tells it
> 	whether to generate references to static cells.
> compiler/code_info.m:
> 	Keep the setting of `--static-ground-terms' in a new code_info_static
> 	field.
> 	Add a getter predicate for the field.
> 	Call `var_locn_assign_cell_to_var' with the value of that field.

That looks fine.

mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list