[m-rev.] for post-commit review: proc commands via reports

Zoltan Somogyi zs at csse.unimelb.edu.au
Mon Aug 25 17:16:30 AEST 2008

On 20-Aug-2008, Paul Bone <pbone at csse.unimelb.edu.au> wrote:
> deep_profiler/create_report.m 
>     in int_per_call uses has an if-then-else as an expression rather
>     than a goal.  I've seen this before in Mercury programs, but havn't
>     seen it documented as an expression.  Is this in the language
>     reference manual?

Yes, it is.

> deep_profiler/query.m:
>     In exec, the variable named FileExists should be named
>     UseOldCGICode, and could perhaps have a type of it's own.

That is part of code that will be deleted soon, so there is no point.

> deep_profiler/util.m:
>     The split predicates here can probably be replaced by, or defined in
>     terms of the split predicates in string.m.

They look like they can, but they cannot. This is because they need to
work with empty fields, which the procedures in string.m remove.

I followed your other suggestions, and incorporated them in my latest diff.

mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au

More information about the reviews mailing list