[m-rev.] for review: add value-threshold of top procedures to deep profiler.

[Julien Fischer]

On Wed, 26 Sep 2007, Paul Bone wrote:

> Estimated hours taken: 1.5
>
> Branches: main
>
> Add the ability to select top procedures in the deep profiling tool based on a
> raw threshold rather than a percentage.  This will be useful when selecting
> procedures to be implicitly parallelized.  Add links to the top-level screen of
> the deep profiler for accessing this feature.
>
> deep_profiler/interface.m
>    Added extra value for display_limit type, threshold_value to represent this
>    new value-based threshold of procedures.
>    Alter string conversion predicates for limits to include this new value and
>    ensure it's distinct from existing values.
>
> deep_profiler/query.m:
>    Added links to main screen to access reports using this feature.  Default
>    thresholds have been chosen.
>
> deep_profiler/top_procs.m:
>    Altered find_top_procs to accept this new display_limit and properly
>    exclude procedures below the value threshold.
>    Added new predicate find_threshold_value_predicate which reference new
>    predicates to select rows above the threshold value.
>    Renamed existing find_threshold_predicate to
>    find_threshold_percent_predicate, as well as the predicates it looks up.

That looks fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------