[m-rev.] diff: fix type checking bug (resend)

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Sep 4 14:15:54 AEST 2007


On Tue, 4 Sep 2007, Mark Brown wrote:

> This didn't get through first time.  Trying again...
>
> ----- Forwarded message from Mark Brown <mark at csse.unimelb.edu.au> -----
>
> Date: Mon, 3 Sep 2007 21:41:13 +1000
> From: Mark Brown <mark at csse.unimelb.edu.au>
> To: Mercury Reviews <mercury-reviews at csse.unimelb.edu.au>
> Subject: diff: fix type checking bug
> User-Agent: Mutt/1.5.16 (2007-06-09)
>
> This fixes a bug reported by Julien a week or two ago.
>
> Cheers,
> Mark.
>
> Estimated hours taken: 5
> Branches: main
>
> Fix a bug in the handling of unsatisfiable typeclass constraints.
>
> compiler/typeclasses.m:
> 	If context reduction fails, continue with the type assign set from the
> 	start of context reduction rather than a type assign set supplied by
> 	the caller, which may be missing information that will later be
> 	required.
>
> compiler/typecheck.m:
> 	Don't pass the original type assign set.
>
> tests/invalid/Mmakefile:
> tests/invalid/typeclass_test_13.err_exp:
> tests/invalid/typeclass_test_13.m:
> 	New test case.
>
> tests/invalid/unsatisfiable_constraint_bug.err_exp:
> 	Update the expected output, now that we have the information
> 	required to produce the correct error meswsage.

Thanks for that.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list