[m-rev.] (reminder) for review: lex moves from Mmakefile to Makefile

Ondrej Bojar bojar at csse.unimelb.edu.au
Fri Mar 2 14:42:22 AEDT 2007


Ralph Becket wrote:
> Ondrej Bojar, Friday,  2 March 2007:
>> Ralph, could you please confirm I'm not breaking you lex intentions? It's a 
>> trivial diff but might not seem so, as whole Mmakefiles get moved to 
>> Makefiles.
> 
> That looks great, thanks!

So I will commit it and post it as a diff (for completeness).

I have another question on you concerning lex.

Some years ago I adapted a copy of lex so that the context returned would be not 
just byte offset but also the line number:

:- type context
     ==      {offset, lineno}.

and also changed the output type for

:- pred read(io__read_result(Tok),
             lexer_state(Tok, Src), lexer_state(Tok, Src)).
:- mode read(out, di, uo) is det.

to

:- pred read(lexer_read_result(Tok), lexer_state(Tok, Src),
             lexer_state(Tok, Src)).
:- mode read(out, di, uo) is det.


where

:- type lexer_read_result(Token)
     --->    ok(Token, context)
     ;       error(string, context)
     ;       eof.

My version is now out of sync with yours. Would you mind if I made the same 
changes to your version?

Thanks, Ondrej.

> --------------------------------------------------------------------------
> mercury-reviews mailing list
> Post messages to:       mercury-reviews at csse.unimelb.edu.au
> Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
> Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
> --------------------------------------------------------------------------

-- 
Ondrej Bojar (mailto:obo at cuni.cz / bojar at ufal.mff.cuni.cz)
http://www.cuni.cz/~obo
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list