[m-rev.] for review: trace goals for erlang

Peter Wang wangp at students.csse.unimelb.edu.au
Thu Jun 14 12:01:49 AEST 2007


On 2007-06-14, Peter Ross <pro at missioncriticalit.com> wrote:
> On Tue, Jun 12, 2007 at 05:55:40PM +1000, Peter Wang wrote:
> > Estimated hours taken: 6
> > Branches: main
> > 
> > Support trace goals and trace runtime conditions in Erlang backend.
> > 
...
> > 
> Looks fine.

Followup (committed).


Estimated hours taken: 0.1
Branches: main

tests/hard_coded/Mmakefile:
	Enable test cases for trace goals with runtime conditions in Erlang.

	Add trace_goal_env_3 to the makefile, which seems to have been missed
	before.

Index: Mmakefile
===================================================================
RCS file: /home/mercury/mercury1/repository/tests/hard_coded/Mmakefile,v
retrieving revision 1.322
diff -u -r1.322 Mmakefile
--- Mmakefile	12 Jun 2007 06:53:58 -0000	1.322
+++ Mmakefile	14 Jun 2007 01:58:24 -0000
@@ -309,6 +309,17 @@
 	MUTABLE_PROGS =
 endif
 
+# Trace goal with runtime conditions work properly only in C and Erlang grades.
+ifeq "$(filter il% java%,$(GRADE))" ""
+	TRACE_GOAL_ENV_PROGS= \
+		trace_goal_env_1 \
+		trace_goal_env_2 \
+		trace_goal_env_2 \
+		trace_goal_env_3
+else
+	TRACE_GOAL_ENV_PROGS=
+endif
+
 # Tests of the C#, MC++, and IL foreign language interfaces only
 # work in IL grades
 ifeq "$(filter il%,$(GRADE))" ""
@@ -329,17 +340,13 @@
 
 # Fact tables currently work only in the C grades.
 # The foreign_type_assertion test is currently meaningful only in C grades.
-# Trace goal with runtime conditions work properly only in C grades.
 # The lookup_disj test case uses C foreign_proc code to print progress reports.
 ifeq "$(filter il% java% erlang%,$(GRADE))" ""
 	C_ONLY_PROGS= \
 		factt \
 		factt_sort_test \
 		foreign_type_assertion \
-		lookup_disj \
-		trace_goal_env_1 \
-		trace_goal_env_2 \
-		trace_goal_env_2
+		lookup_disj
 else
 	C_ONLY_PROGS=
 endif
@@ -555,7 +562,7 @@
 		$(C_AND_GC_ONLY_PROGS) $(STATIC_LINK_PROGS) \
 		$(CHAR_REP_PROGS) $(C_ONLY_PROGS) \
 		$(DOTNET_PROGS) $(JAVA_PROGS) $(TRAILED_PROGS) \
-		$(MUTABLE_PROGS) 
+		$(MUTABLE_PROGS) $(TRACE_GOAL_ENV_PROGS)
 endif
 
 #-----------------------------------------------------------------------------#
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list