[m-rev.] For review: Annotate the HLDS with regions

Quan Phan Quan.Phan at cs.kuleuven.be
Thu Jul 5 17:59:37 AEST 2007


Hi Julien,

Quoting Julien Fischer <juliensf at csse.unimelb.edu.au>:

> 
> In future could you please use the interdiff program to create a relative
> diff between your original diff and the revised one.

Yes, I will.

> 
> I'm happy for you to commit this after the above comments are addressed
> and this change has bootchecked. 

I will commit this change after bootchecking.

> As I mentioned in my last set of 
> review comments (and we discussed in person) the representation of region
> instructions should not be a string; you can fix that as a separate
> change.  

I agree. 

> Also, I think the above code unnecessarily traverses the HLDS
> in some places and that the whole region renaming thing can either
> be simplified (or possible avoided altogether); looking into these
> matters is a separate change.

I will write up the problem and my solution for it. After that we can see better
what actually need to be done.

Thanks,
Quan

> 
> Julien.
> 
> 
> 
> --------------------------------------------------------------------------
> mercury-reviews mailing list
> Post messages to:       mercury-reviews at csse.unimelb.edu.au
> Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
> Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
> --------------------------------------------------------------------------
> 



--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list