[m-rev.] for review: build Mercury using MSVC 6

Julien Fischer juliensf at csse.unimelb.edu.au
Sun Feb 18 11:10:36 AEDT 2007



On Sat, 17 Feb 2007, Peter Ross wrote:

> ===================================================================
>
>
> Build Mercury using MSVC 6.
>
> boehm_gc/NT_MAKEFILE:
> 	msvc_dbg.c is in the include\private directory.
>
> boehm_gc/msvc_dbg.c:
> 	Define ULONG_PTR as an int.
>
> compiler/prog_event.m:
> 	ssize_t isn't defined under windows.
>
> library/par_builtin.m:
> 	The CL compiler doesn't accept empty structs.
>
> robdd/Makefile:
> 	-Wall isn't a valid option to CL.
>
> runtime/mercury_mm_own_stacks.c:
> runtime/mercury_term_size.c:
> 	Conditionally import unistd.h
>
> runtime/mercury_trace_base.c:
> 	Use the correct version of snprintf.
> 	Fix the MR_FILE_EXISTS macro to work under win32.
>

...

> Index: library/par_builtin.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/library/par_builtin.m,v
> retrieving revision 1.9
> diff -u -r1.9 par_builtin.m
> --- library/par_builtin.m	6 Feb 2007 06:47:35 -0000	1.9
> +++ library/par_builtin.m	17 Feb 2007 11:42:27 -0000
> @@ -82,6 +82,7 @@
>     };
> #else /* !MR_THREAD_SAFE */
>     struct MR_Future {
> +        int x;
>     };
> #endif /* !MR_THREAD_SAFE */

I suggest s/x/dummy/ and also add a comment along the lines of:

 	ANSI C does not support empty structs.

The rest looks okay.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list