[m-rev.] for review: initialisers and uncaught exceptions

Mark Brown mark at csse.unimelb.edu.au
Thu Feb 8 01:34:59 AEDT 2007


On 08-Feb-2007, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> 
> On Thu, 8 Feb 2007, Mark Brown wrote:
> 
> >On 08-Feb-2007, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
> >>+# init_excp.out is expected to fail (it calls throw/1).
> >>+#
> >>+init_excp.out: init_excp
> >>+	if ./init_excp > $@.tmp 2>&1; then \
> >>+		grep  . $@.tmp; \
> >
> >What does this do (apart from remove empty lines)?  Same question applies
> >to the already existing no_fully_strict test.
> 
> I assumed that it was so the output showed up in the test logs.  (The
> tests in the tabling directory are run that way as well.)

Yes, but why not just use cat?

I guess there's a good reason since the other tests do it.  I am just
curious.

> 
> >>+		exit 1; \
> >>+	else \
> >>+		cat $@.tmp > $@; \
> >>+		rm -f $@.tmp; \
> >>+	fi
> >
> >What happens in grades where stack dumps are available?  You may need to
> >filter out line numbers from exception.m.
> 
> Done.
> 
> Did you have any comments the reference manual change?

The rest of the change is fine.

Cheers,
Mark.

--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list