[m-rev.] Fixes for test output

Ian MacLarty maclarty at csse.unimelb.edu.au
Tue Aug 21 16:28:17 AEST 2007


On Tue, Aug 21, 2007 at 03:03:02PM +1000, Ralph Becket wrote:
> Estimated hours taken: 4 (mostly testing)
> Branches: main
> 
> library/list.m:
> 	Improve the pretty-printer formatting of lists by preventing
> 	the output of ellipsis when all items in the list have been
> 	printed.
> 
> library/pretty_printer.m:
> 	Some term names output by the debugger are module qualified.
> 	Prevent the default term formatting code from quoting names
> 	that contain '.'s unless they also contain other characters
> 	requiring quoting.
> 

I think a better fix would be to modify synthetic_term_to_doc in
browser/browse.m to look for dots in the predicate or function name and
generated the appropriate doc.  Then change the pretty printer to not
put spaces around '.' infix operators.

With your current fix, it will be harder to use the pretty printer to
output generated Mercury code where functors might contain dots.

...
> Index: tests/debugger/browser_test.exp
> ===================================================================
> RCS file: /home/mercury1/repository/tests/debugger/browser_test.exp,v
> retrieving revision 1.28
> diff -u -r1.28 browser_test.exp
> --- tests/debugger/browser_test.exp	19 Jan 2007 04:42:47 -0000	1.28
> +++ tests/debugger/browser_test.exp	20 Aug 2007 01:30:29 -0000
> @@ -1,4 +1,10 @@
>        E1:     C1 CALL pred browser_test.main/2-0 (det) browser_test.m:16
> +Goal path printing is now on.
> +Registering debuggable procedures... done.
> +There is one debuggable module, with 7 procedures.
> +mdb: there is no such procedure.
> +mdb: xml_browser_cmd: usage error -- type `help xml_browser_cmd' for help.

Why are you getting these errors now?  They seem unrelated to your
changes.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list