[m-rev.] for review: add a note about the behaviour of foreign_import_module

Julien Fischer juliensf at csse.unimelb.edu.au
Fri Aug 10 16:15:17 AEST 2007


On Fri, 10 Aug 2007, Mark Brown wrote:

> On 10-Aug-2007, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>>
>> On Fri, 10 Aug 2007, Mark Brown wrote:
>>
>>> On 10-Aug-2007, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>>>>
>>>> For review by anyone.
>>>>
>>>> Estimated hours taken: 0.2
>>>> Branches: main
>>>>
>>>> Add a note about the behaviour of the Mercury implementation with
>>>> respect to foreign_import_module pragmas.
>>>>
>>>> doc/reference_manual.texi:
>>>> 	Mention that the Melbourne Mercury implementation sometimes
>>>> 	implicitly creates foreign_import_module pragmas.
>>>>
>>>> Julien.
>>>>
>>>> Index: reference_manual.texi
>>>> ===================================================================
>>>> RCS file:
>>>> /home/mercury/mercury1/repository/mercury/doc/reference_manual.texi,v
>>>> retrieving revision 1.401
>>>> diff -u -r1.401 reference_manual.texi
>>>> --- reference_manual.texi	25 Jul 2007 06:12:28 -0000	1.401
>>>> +++ reference_manual.texi	10 Aug 2007 05:27:29 -0000
>>>> @@ -7079,6 +7079,12 @@
>>>>  A cycle of @samp{pragma foreign_import_module}, where the language is
>>>>  @samp{"C#"} or @samp{"Java"}, is not permitted.
>>>>
>>>> +Note that the Melbourne Mercury implementation may sometimes implicitly
>>>> insert
>>>> + at samp{pragma foreign_import_module} declarations
>>>
>>> It might be helpful to add ", when using the high-level backend for
>>> example, "
>>> or something like that.  Otherwise this change is good.
>>
>> It's not just the high-level backend though.  Compiling with
>> --intermodule-optimization enabled, in any grade, will have a similar
>> effect.
>
> Yes, I don't think you need to exhaustive list.  The example is just to
> give an idea of how frequently the implicit import might occur (that is,
> "quite frequently", or even "usually").  Perhaps instead you should
> replace "may sometimes implicitly insert" with "often implicitly inserts".

Ok, I've done that.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list