[m-rev.] For review: Remove --region-analysis option

Quan Phan quan.phan at cs.kuleuven.be
Wed Aug 8 22:06:48 AEST 2007


Hi,

Estimate hours taken: 0.5

Remove option --region-analysis because it is no longer needed. To turn on
region-based memory management now we just use --use-regions in .rbmm grade.

compiler/options.m:
	Remove the --region-analysis option.
	An unrelated change but no harm: provide default values for some
	region structures. 

compiler/mercury_compile.m
	Use --use-regions to turn on region analysis.

Regards,
Quan

Index: mercury_compile.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/mercury_compile.m,v
retrieving revision 1.446
diff -u -r1.446 mercury_compile.m
--- mercury_compile.m	8 Aug 2007 05:08:40 -0000	1.446
+++ mercury_compile.m	8 Aug 2007 10:07:22 -0000
@@ -4248,7 +4248,7 @@
 
 maybe_region_analysis(Verbose, Stats, !HLDS, !IO) :-
     module_info_get_globals(!.HLDS, Globals),
-    globals.lookup_bool_option(Globals, region_analysis, Analysis),
+    globals.lookup_bool_option(Globals, use_regions, Analysis),
     (
         Analysis = yes,
         maybe_write_string(Verbose, "% Analysing regions ...\n", !IO),
Index: options.m
===================================================================
RCS file: /home/mercury/mercury1/repository/mercury/compiler/options.m,v
retrieving revision 1.581
diff -u -r1.581 options.m
--- options.m	31 Jul 2007 07:58:42 -0000	1.581
+++ options.m	8 Aug 2007 10:07:25 -0000
@@ -587,7 +587,6 @@
     ;       distance_granularity
     ;       parallelism_target
     ;       implicit_parallelism
-    ;       region_analysis
 
     % Stuff for the CTGC system (structure sharing / structure reuse).
     ;       structure_sharing_analysis
@@ -1195,15 +1194,15 @@
     use_minimal_model_stack_copy_pneg   -   bool(no),
     use_minimal_model_stack_copy_cut    -   bool(no), 
     disable_trail_ops                   -   bool(no),
-    % The size_region_* values are just dummies for now; Quan, please set them.
+    % The values here must be consistent with those in mercury_region.h.
     size_region_ite_fixed               -   int(4),
     size_region_disj_fixed              -   int(4),
-    size_region_commit_fixed            -   int(4),
-    size_region_ite_protect             -   int(0),
-    size_region_ite_snapshot            -   int(0),
-    size_region_disj_protect            -   int(0),
-    size_region_disj_snapshot           -   int(0),
-    size_region_commit_entry            -   int(0)
+    size_region_commit_fixed            -   int(3),
+    size_region_ite_protect             -   int(1),
+    size_region_ite_snapshot            -   int(4),
+    size_region_disj_protect            -   int(2),
+    size_region_disj_snapshot           -   int(4),
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list