[m-rev.] diff: cleanup library/rtree.m

[Julien Fischer]

On Mon, 16 Oct 2006, Zoltan Somogyi wrote:

> On 16-Oct-2006, Julien Fischer <juliensf at csse.unimelb.edu.au> wrote:
>> -        % Tests whether two regions intersect.
>> +        % Succeeds iff if two regions intersect.
>
> s/iff if/iff/

Fixed.

>> -        % Computes the "size" of a region.
>> +        % Returns the "size" of a region.
>>          % e.g. for a 2D box, the "size" is equivalent to area.
>
> What about non-2d boxes?

It depends on what the user defines size to mean for the a specific
region.  Perhaps it should say something like the following:

 	e.g. for a region that is a 2D box one measure of size would
 	     be its area.

>> -        % Computes a bounding region that contains both input regions.
>> -        % The resulting region should be as small as possible.
>> +        % Returns a minimal bounding region that contains both
>> +        % input regions.
>
> Document the fact that the bounding region must also be a box, which affects
> what is "minimal".

I take it you meant to say that the bounding region must itself also be a region.
(If so, fixed.)

>> -    % Check whether an rtree is empty.
>> +    %  Succeeds iff the given rtree is empty.
>
> s/%  S/% S/

Fixed.

> I didn't look at the diff for the implementation, since I haven't read
> Guttman's paper.

There are no algorithmic changes to the original implementation.
There's a copy of Guttman's paper on my desk if you're interested in
reading it.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------