[m-rev.] for review: fix a name mangling bug in hlc grades

Julien Fischer juliensf at csse.unimelb.edu.au
Tue Nov 14 13:43:19 AEDT 2006


On Tue, 14 Nov 2006, Ian MacLarty wrote:

> For review by anyone.
>
> Estimated hours taken: 1
> Branches: main
>
> Fix a bug in the hlc grades where generated C function names were not
> being mangled correctly.  The generated function names contained the
> Mercury module name verbatim, which meant that if the Mercury module name
> wasn't a valid C identifier, then the generated C code would be invalid.
>
> compiler/mlds_to_c.m:
> 	Mangle function names in generated high level C code.
>
> tests/general/Mmakefile:
> tests/general/hlc_name_mangling-helper-module.m:
> tests/general/hlc_name_mangling.exp:
> tests/general/hlc_name_mangling.m:
> 	Add a regression test.
>

That looks fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------



More information about the reviews mailing list