[m-rev.] diff: --smart-recompilation and sub-modules bug

[Julien Fischer]

On Wed, 22 Mar 2006, Julien Fischer wrote:

>
> On Wed, 22 Mar 2006, Peter Ross wrote:
>
> > On Wed, Mar 22, 2006 at 04:08:01PM +1100, Zoltan Somogyi wrote:
> > > On 22-Mar-2006, Peter Ross <pro at missioncriticalit.com> wrote:
> > > >  insert_into_imported_items_map(VisibleModule, !ImportedItemsMap) :-
> > > >      ModuleItems = init_item_id_set(set.init),
> > > > -    svmap.det_insert(VisibleModule, ModuleItems, !ImportedItemsMap).
> > > > +    svmap.set(VisibleModule, ModuleItems, !ImportedItemsMap).
> > >
> > > I think there should be a comment on the call to set here to say why
> > > we call set instead of det_insert.
> > >
> > Adding
> >
> >         %
> >         % Use set rather than det_insert as this routine maybe
> >         % called multiple times with the same VisibleModule
> >         % depending on why the module is visible.
> >         % eg it's both imported and an ancestor module
> >         %
> >
> > Also there is no test case because test/hard_coded/submodules/deeply_nested
> > tickles this bug as well.
>
> I think I'll add the other test case anyway since otherwise this bug won't
> be tickled on any of our machines that test with `--intermod-opt', which
> is pretty much all of them.
>

To say nothing of the fact that hard_coded/submodules/deeply_nested is run
without smart recompilation enabled ;-)

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------