[m-rev.] for review: add 4 new mdb commands

[Julien Fischer]

On Tue, 14 Mar 2006, Ian MacLarty wrote:

> On Mon, Mar 13, 2006 at 02:36:12PM +1100, Zoltan Somogyi wrote:
> > On 12-Mar-2006, Ian MacLarty <maclarty at cs.mu.OZ.AU> wrote:
> > > ===================================================================
> > > RCS file: tests/debugger/shell.exp
> > > diff -N tests/debugger/shell.exp
> > > --- /dev/null	1 Jan 1970 00:00:00 -0000
> > > +++ tests/debugger/shell.exp	11 Mar 2006 16:44:38 -0000
> > > @@ -0,0 +1,10 @@
> > > +Melbourne Mercury Debugger, mdb version DEV.
> > > +Copyright 1998-2006 The University of Melbourne, Australia.
> > > +mdb is free software, covered by the GNU General Public License.
> > > +There is absolutely no warranty for mdb.
> > > +      E1:     C1 CALL pred shell.main/2-0 (det) shell.m:12
> > > +mdb> echo on
> > > +Command echo enabled.
> > > +mdb> shell echo hello
> > > +hello
> > > +mdb> quit -y
> > > Index: tests/debugger/shell.inp
> > > ===================================================================
> > > RCS file: tests/debugger/shell.inp
> > > diff -N tests/debugger/shell.inp
> > > --- /dev/null	1 Jan 1970 00:00:00 -0000
> > > +++ tests/debugger/shell.inp	11 Mar 2006 20:45:51 -0000
> > > @@ -0,0 +1,6 @@
> > > +echo on
> > > +shell echo hello
> > > +alias test source shell_test_script
> > > +test value1 value2 3 'value 4' "a" '' 'b' file_name.ext 9
> > > +test only_one_value
> > > +quit -y
> >
> > I don't see the effect of
> >
> > 	test value1 value2 3 'value 4' "a" '' 'b' file_name.ext 9
> > 	test only_one_value
> >
> > in the expected output file.
> >
>
> Sorry, I included the wrong shell.exp.  It should have been:
>
>       E1:     C1 CALL pred shell.main/2-0 (det) shell.m:12
> mdb> echo on
> Command echo enabled.
> mdb> shell echo hello
> hello
> mdb> alias test source shell_test_script
> test   =>    source shell_test_script
> mdb> test value1 value2 3 'value 4' "a" '' 'b' file_name.ext 9
> value1 value2
> value2 value1
> value1 value2 $ $abc 3 value 4 a b file_name.ext 9 $0 $b $
> mdb> test only_one_value
> only_one_value
> only_one_value
> only_one_value $ $abc $0 $b $
> mdb> quit -y
>
> > Apart from that and a typo ("occurrence" spelt with one 'c'), I agree with
> > Julien's comments.
> >
>
> Okay I will make the requested changes and submit an interdiff in the
> next few days.  I have one problem though:  I don't think edit is a good
> name for the command to invoke the editor since it suggests that you're
> updating the value of the term in the program, which you're not.  What
> about 'open' or 'view'?

Either seems okay, although I'd lean towards the latter.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------