[m-rev.] for review: don't remove grade files after installing

[Simon Taylor]

On 04-Dec-2006, Peter Wang <wangp at students.csse.unimelb.edu.au> wrote:
> On 2006-12-04, Simon Taylor <staylr at gmail.com> wrote:
> > On 04-Dec-2006, Peter Wang <wangp at students.csse.unimelb.edu.au> wrote:
> > > Estimated hours taken: 0.5
> > > Branches: main
> > > 
> > > compiler/make.program_target.m:
> > > 	Don't remove grade-dependent files after installing a library with
> > > 	`mmc --make' if `--use-grade-subdirs' is used.
> > 
> > I think that will only work if there is only one grade to install,
> > otherwise it will leave the grade dependent files for the last grade
> > installed.  It would be better to move the grade dependent directory
> > away (if it exists) before installing the other grades, then move it
> > back afterwards.
> 
> Move away which grade dependent directory?  I don't follow.

Sorry, you're right.  I misremembered how that works.

> I hadn't thought of this earlier, but my patch does cause the
> copies/symlinks from the last installed grade to be left in the current
> directory.

Also, you missed a spot.  If the user interrupts the installation
the call to build_with_check_for_interrupt in install_library_grade
will call make_grade_clean (which I just noticed will always clean
up the files for the default grade, not the grade being installed).

Simon.
--------------------------------------------------------------------------
mercury-reviews mailing list
Post messages to:       mercury-reviews at csse.unimelb.edu.au
Administrative Queries: owner-mercury-reviews at csse.unimelb.edu.au
Subscriptions:          mercury-reviews-request at csse.unimelb.edu.au
--------------------------------------------------------------------------