[m-rev.] for review: mercury installer script
Julien Fischer
juliensf at cs.mu.OZ.AU
Tue Nov 22 15:35:34 AEDT 2005
On Mon, 21 Nov 2005, Ian MacLarty wrote:
> There is an sample installer available from
> http://www.cs.mu.oz.au/~maclarty/mercury-compiler-DEV-2005-11-21.msi.
> It contains the grades asm_fast.gc, hlc.gc, asm_fast.gc.tr.debug and
> asm_fast.gc.decldebug.
>
> Any feedback would be welcome.
>
Have you thought of perhaps splitting the debugger (and related grades)
off into a separate package of its own?
> Note that the compiler hasn't worked with Windows 98 since we updated
> the garbage collector (it segfaults).
>
Windows 98 support isn't important (aside from on your laptop)
> mmc and mdb should work out of the box from the Windows command prompt.
> mmake doesn't work and I haven't tested any of the other tools.
>
The only other really important one would be mprof.
> Estimated hours taken: 3
> Branches: main
>
> Create a script to generate a Windows installer for Mercury.
>
> extras/windows_installer_generator/wix_gui.m:
> Increase the size of some text areas.
>
> extras/windows_installer_generator/wix.m:
> extras/windows_installer_generator/wix_installer.m:
> Add a new installer option that determines whether the installation
> is per-machine or per-user.
>
> extras/windows_installer_generator/sample/README:
> Mention the new gen_merc_msi script.
>
> extras/windows_installer_generator/sample/Mercury.config:
> Add a custom configuration file for the Windows installer.
> The only difference is that MERCURY_STDLIB_DIR is set from
> MERCURY_CONFIG_DIR instead of being hard coded.
>
> extras/windows_installer_generator/sample/gen_merc_msi:
> Add a script for building a Mercury installer.
>
> extras/windows_installer_generator/sample/gen_merc_wxs.m:
> Set the MERCURY_CONFIG_DIR and MERCURY_DEBUGGER_INIT
> environment variables on installation.
> Add some more comments at the welcome and finish steps.
> Make the installation per-machine, so that the documentation
> shortcuts are created for all users.
>
> extras/windows_installer_generator/sample/mdb.bat:
> Add a custom mdb script for the windows installer.
>
> extras/windows_installer_generator/sample/mdbrc:
> Add a custom mdbrc file for the windows installer.
>
> extras/windows_installer_generator/sample/images/banner.bmp:
> extras/windows_installer_generator/sample/images/bg.bmp:
> Update these images slightly.
>
> Index: extras/windows_installer_generator/wix.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/extras/windows_installer_generator/wix.m,v
> retrieving revision 1.1
> diff -u -r1.1 wix.m
> --- extras/windows_installer_generator/wix.m 26 Oct 2005 05:04:15 -0000 1.1
> +++ extras/windows_installer_generator/wix.m 21 Nov 2005 11:07:00 -0000
> @@ -14,6 +14,7 @@
>
> :- interface.
>
> +:- import_module bool.
> :- import_module int.
> :- import_module io.
> :- import_module list.
> @@ -93,6 +94,9 @@
> % menu (see the definition of the shortcut_function
> % type below).
> wix_shortcut_func :: shortcut_function(L),
> +
> + % If yes then the shortcuts will be visible to all users.
> + wix_all_users :: bool,
>
> % A token representing the text to display in the
> % title bar of the installer GUI.
> Index: extras/windows_installer_generator/wix_gui.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/extras/windows_installer_generator/wix_gui.m,v
> retrieving revision 1.1
> diff -u -r1.1 wix_gui.m
> --- extras/windows_installer_generator/wix_gui.m 26 Oct 2005 05:04:16 -0000 1.1
> +++ extras/windows_installer_generator/wix_gui.m 21 Nov 2005 11:07:00 -0000
> @@ -326,7 +326,7 @@
> dialog(finish_dlg, 370 - 270, Title, not_modeless, [
> button(236 - 243, 56 - 17, not_default, Finish, [exit]),
> bitmap(0 - 0, 370 - 234, BackgroundSrc),
> - text(135 - 70, 220 - 60, Message, normal),
> + text(135 - 70, 220 - 160, Message, normal),
> text(135 - 20, 220 - 60, Heading, heading),
> line(0 - 234, 370 - 0)]).
>
> @@ -689,7 +689,7 @@
> WizardStep = wizard_start(Heading, Message),
> Background = [bitmap(0 - 0, 370 - 234, BackgroundSrc)],
> HeadingText = [text(135 - 20, 220 - 60, Heading, heading)],
> - MessageText = [text(135 - 70, 220 - 30, Message, normal)],
> + MessageText = [text(135 - 70, 220 - 160, Message, normal)],
> BottomLine = [line(0 - 234, 370 - 0)],
> WizControls = NextButton ++ CancelButton ++
> HeadingText ++ MessageText ++ Background ++
> Index: extras/windows_installer_generator/wix_installer.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/extras/windows_installer_generator/wix_installer.m,v
> retrieving revision 1.1
> diff -u -r1.1 wix_installer.m
> --- extras/windows_installer_generator/wix_installer.m 26 Oct 2005 05:04:16 -0000 1.1
> +++ extras/windows_installer_generator/wix_installer.m 21 Nov 2005 11:07:00 -0000
> @@ -39,6 +39,7 @@
>
> :- implementation.
>
> +:- import_module bool.
> :- import_module exception.
> :- import_module int.
> :- import_module list.
> @@ -62,7 +63,8 @@
> ann_installer_bitmaps :: map(string, id),
> ann_installer_removedlg_id :: id,
> ann_installer_finish_id :: id,
> - ann_installer_checkifadmin :: maybe(string)
> + ann_installer_checkifadmin :: maybe(string),
> + ann_insatller_all_users :: bool
s/ann_insatller_all_users/ann_installer_all_users/
The rest looks ok (although I didn't have a very close look at it all).
Cheers,
Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post: mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------
More information about the reviews
mailing list