[m-rev.] For review: more fixes to impurity

Julien Fischer juliensf at cs.mu.OZ.AU
Fri Nov 18 15:35:27 AEDT 2005


On Fri, 18 Nov 2005, Ralph Becket wrote:

> Estimated hours taken: 2
> Branches: main
>
> Remove now incorrect errors of the form "unification with expression was
> declared impure, but expression was not a function call."
>
> compiler/purity.m:
> 	Prevent purity.m from reporting unifications marked with
> 	impure as errors: unifications *can* be impure if they
> 	unify two inst any variables in a negated context.  Purity
> 	error reporting for unifications is now handled in modecheck_unify.m.
>
The fact that unifications can now have purity annotations attached to
them should be mentioned in the purity section of the reference manual.

> compiler/field_access.m:
> compiler/superhomogeneous.m:
> 	Include unification impurity annotations in the corresponding goal
> 	infos, rather than discarding them or reporting an error.
>
> tests/invalid/purity/impure_func_t7.err_exp:
> tests/invalid/purity/impure_func_t7.m:
> 	Break the test cases into separate predicates.
> 	Update the expected error output.
>
You will probably also need to have a look at
tests/warnings/purity_warnings as well.

The rest looks fine.

Julien.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list