[m-rev.] for review: new termination analyser (part 1 of 6)

[Mark Brown]

Some initial remarks...

On 24-Mar-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> compiler/termination2.m:

This isn't the clearest of module names; perhaps calling this module
term_constr.m would be better.  Alternatively, you could call the other
new modules term2_*.m to make it clear which modules go together.

> 	New file.  Invokes the the other passes of the new analysis
> 	and handles the output termination2_info pragmas to .opt

s/output/output of/

> 	and .trans_opt files.
> 
> 	XXX I've disable the writing out of termination2_info

s/disable/disabled/

> 	pragmas to the (transitive-)intermodule optimization files
> 	until I've updated the test suite.
> 

> compiler/term_constr_initial.m:
> 	New file.  Sets up information for builtin and compiler
> 	generated procedures and process information about

s/process/processes/

> 	imported procedures.  Also handles termination pragmas.
> 

> compiler/lp_rational.m:
> 	Provides the necessary machinery for manipulating systems
> 	of linear constraints.  Originally committed on the termination2
> 	branch although most of this version new.  (Some bits of the

s/version/version is/

> 	version on the termination2 branch are now in polyhedron.m).
> 	The linear solver is essentially the one that is currently
> 	in lp.m converted to use rationals rather than floats.
> 

> compiler/goal_form.m:
> 	When checking whether a goal can loop or not use
> 	information form the new termination analyser as well as

s/form/from/

> 	the old one.
> 
> compiler/globals.m:
> compiler/handle_options:
> compiler/options.m:
> 	Add options to control the new analyser.  The documentation
> 	is currently commented out.

You should (briefly) state here why it is commented out and when it should
be uncommented.

--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------