[m-rev.] diff: more :- import_module updates, and tree.m

Zoltan Somogyi zs at cs.mu.OZ.AU
Thu Mar 24 14:56:24 AEDT 2005


On 24-Mar-2005, Julien Fischer <juliensf at cs.mu.OZ.AU> wrote:
> > 	Fix a performance problem I noticed while update :- import_module
> > 	items. Instead of supplying a function to convert lists of trees
> > 	to a tree, make the tree data structure able to hold a list of
> > 	subtrees directly. This reduces the number of times where we have to
> > 	convert list of trees to trees that are sticks just to stay within
> > 	the old definition of what a tree is.
> 
> Does this make a noticeble difference?

I don't think so. I did it mostly because I remember that updating the
nested trees is very error prone; it is too easy to accidentally delete
one of the parentheses in the forest of ))))s at the end :-(, and I wanted
to fix that without introducing a slowdown of any significant magnitude.

Zoltan.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list