[m-rev.] for review: new mdbcomp directory

Ian MacLarty maclarty at cs.mu.OZ.AU
Fri Jan 28 12:04:51 AEDT 2005


On Thu, Jan 27, 2005 at 03:49:51PM +1100, Zoltan Somogyi wrote:
> Mmakefile:
> 	Make invocations visit the mdbcomp library as necessary.
> 
> 	Improve the way we install grades. Making temporary backups of the
> 	directories modified by the install process is unsatisfactory for two
> 	reasons. First, if the install fails, the cleanup script, which is
> 	necessary for use friendliness, destroys any evidence of the cause.

s/use/user/

> 	Second, the restore of the backup wasn't perfect, e.g. it left the
> 	.d files modified to depend on .mih files, which don't exist in
> 	LLDS grades, and also left altered timestamps.
> 
> 	This diff changes the install process to make a single tmp_dir
> 	subdirectory of the workspace, with all the work of install_grade
> 	being done inside tmp_dir. The original directories aren't touched
> 	at all.
> 
> */Mmakefile:
> 	Adjust references to the browser directory to refer to the mdbcomp
> 	directory instead or as well.
> 
> scripts/Mmake.rules:
> */Mmakefile:
> 	Make it easier to debug Mmakefiles. Previously, create a Mmake.makefile

s/create/creating/

> 	with mmake -s and invoking "make -d" ignored the most fundamental rules
> 	of mmake, because Mmake.rules was treating an under MMAKE_USE_MMC_MAKE

s/under/unset/

> 	as if it were set to "yes", simply because it was different from "no".
> 	This diff changes it to treat an unset MMAKE_USE_MMC_MAKE as if it
> 	were set to "no", which is a more sensible default.
> 
> scripts/prepare_tmp_dir_fixed_part.in:
> scripts/scripts/prepare_tmp_dir_grade_part:
> 	Two new scripts that each do half the work of preparing tmp_dir for
> 	the real work of the install_grade make target. The fixed_part script
> 	prepares the parts of tmp_dir that are grade-independent, while the
> 	grade_part scripts prepares the parts that are grade-dependent.
> 
> configure.in:
> 	Test C files in the mdbcomp directory to see whether they need to
> 	recompiled after reconfiguration.

s/recompiled/be recompiled/

> 
> 	Create prepare_tmp_dir_fixed_part from prepare_tmp_dir_fixed_part.in.
> 
> compiler/*.m:
> runtime/mercury_wrapper.c:
> 	Update the references to the moved files.
> 
> compiler/notes/overall_design.html:
> 	Mention the new directory.
> 
> cvs diff: Diffing .

> Index: library/Mmakefile
> ===================================================================
> @@ -481,9 +483,10 @@
>  	rm -f $(INSTALL_MODULE_DIR)/library.init \
>  		$(INSTALL_MODULE_DIR)/libmercury.init
>  
> -
>  ifneq (,$(findstring il,$(GRADE)))
>  
> +# some modules of in the browser directory need library.int3

delete "of".

> Index: mdbcomp/mdbcomp.m
> ===================================================================
> RCS file: mdbcomp/mdbcomp.m
> diff -N mdbcomp/mdbcomp.m
> --- /dev/null	1 Jan 1970 00:00:00 -0000
> +++ mdbcomp/mdbcomp.m	19 Jan 2005 04:20:25 -0000
> @@ -0,0 +1,47 @@
> +%---------------------------------------------------------------------------%
> +% Copyright (C) 2003, 2005 The University of Melbourne.
> +% This file may only be copied under the terms of the GNU Library General
> +% Public License - see the file COPYING.LIB in the Mercury distribution.
> +%---------------------------------------------------------------------------%
> +%
> +% This is the top module of a library that contains information shared
> +% between the debugger and the compiler. This means mostly the definitions
> +% of data structures that the compiler generates for the debugger, and
> +% the predicates that operate on them.
> +%
> +% The compiler links in this library in all grades, but links in the mdb
> +% library (which also in this directory) only when debugging is enabled.

s/which also/which is also/

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list