[m-rev.] diff: speed up common.m worst case

Ralph Becket rafe at cs.mu.OZ.AU
Mon Jan 24 18:06:49 AEDT 2005


Zoltan Somogyi, Monday, 24 January 2005:
> compiler/common.m:
> 	Make this pass significantly more efficient when operating on
> 	predicates with many opportunities for reusing common structures.
> 	The speed when compiling the six largest compiler modules is virtually
> 	unaffected, but the time to compile a module generated by caribou
> 	has dropped from 79 seconds to 56, a 30% reduction.

This looks fine, except that the coding standards specify that comments
should appear as

	% blah blah blah
	% blah blah blah
	% blah blah blah
	%
:- thing the comment pertains to.

You're missing the connecting, empty comment line throughout.

-- Ralph
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list