[m-rev.] for review: fix debugger namespace cleanliness

Ian MacLarty maclarty at cs.mu.OZ.AU
Sat Jan 22 14:46:14 AEDT 2005


On Sat, Jan 22, 2005 at 01:47:45AM +1100, Julien Fischer wrote:
> 
> For post-commit review by Ian.
> 
> (I committed this because it's breaking the nightly builds
>  on ceres and almery.)
> 
> Estimated hours taken: 1
> Branches: main
> 
> The namespace cleanliness check in the browser directory
> has been failing in the high-level C grades.  This is
> because the symbols exported from term_rep did not have
> one of the expected prefixes.  Fix this by making term_rep
> part of the mdb package.
> 

I didn't make it part of the mdb package because it's a fairly general
purpose module.  That looks fine what you've done, but what's the
reason you didn't just add "term_rep" to the list of expected prefixes?

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------



More information about the reviews mailing list