[m-rev.] for review: add `mode' command to interactive term browser

[Ian MacLarty]

On Mon, Jan 17, 2005 at 02:12:29AM +1100, Julien Fischer wrote:
> >
> > browser/declarative_oracle.m
> > 	The wrong_answer functor now has 3 arguments.
> >
> Why does it now have 3 arguments?  That statement by itself is not
> particularly helpful.
> 
I've changed the log message to:

	Conform to the fact that wrong answers now also have the
	initial atom.

> >  	% The interactive term browser.  The caller type will be `browse', and
> > +	% the default format for the `browse' caller type will be used.  Since
> > +	% this predicate is exported to be used by C code, no mode function
> > +	% can be supplied.
> > +	%
> It would proably be better to refer to it consistently as a "browse mode
> function" rather than a "mode function".
> 

I don't know.  "browse mode function" sounds like something to do with the
mode the browser is operating in.  I think just "mode function" is less 
confusing.  What about "browser term mode function"?

> > +	% A signature for functions that can be used by the browser to work
> > +	% out the mode of a sub-term.
> > +	%
> > +:- type browser_mode_func == (func(list(dir)) = browser_term_mode).
> > +
> > +	% The possible modes of a sub-term in the browser.  Note these do
> > +	% not correspond directly with the declared Mercury modes.
> > +	%
> > +:- type browser_term_mode
> > +			% The sub-term is bound at the call.  This could
> > +			% correspond to the Mercury modes `in', `di', `ui',
> > +			% etc.
> 
> I suggest something like:
> 
> 	The sub-term is bound at the cell.  For example
> 	the Mercury builtin modes, `in', `di' and `ui'.
> 

Okay.

> > +
> > +test(_) :-
> > +	semidet_fail.
> > +
> > +:- pred p(character, int).
> I'd suggest s/character/char/ there - see the comments at the start of
> char.m (and below).
> 

Done.

Thanks,

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------