[m-rev.] for review: improve error message for pragma export and model_non code

[Ian MacLarty]

On Wed, Jan 05, 2005 at 02:25:15PM +1100, Julien Fischer wrote:

> Index: compiler/det_analysis.m
> ===================================================================
> RCS file: /home/mercury1/repository/mercury/compiler/det_analysis.m,v
> retrieving revision 1.172
> diff -u -r1.172 det_analysis.m
> --- compiler/det_analysis.m	10 Dec 2004 07:03:43 -0000	1.172
> +++ compiler/det_analysis.m	22 Dec 2004 03:50:51 -0000
> @@ -314,6 +314,26 @@
>  	proc_info_set_goal(Goal, Proc0, Proc1),
>  	proc_info_set_inferred_determinism(Detism, Proc1, Proc),
> 
> +	% Check to make sure that if this procedure is exported to
> +	% C via a pragma export declaration then the determinism
> +	% is not multi or nondet - pragma exported procs that have
> +	% been declared to have these determinisms should have been
> +	% picked up in make_hlds, so this is just to catch those whose
> +	% determinisms need to be inferred.
> +
> +	module_info_get_pragma_exported_procs(!.ModuleInfo,
> +		ExportedProcs),
> +	(
> +		list.member(pragma_exported_proc(PredId, ProcId, _, _),
> +			ExportedProcs),
> +		( Detism = multidet ; Detism = nondet)

There should be a space before the end brace.

Otherwise this looks fine, although I'm not that familiar with the
areas of the compiler you changed.

Ian.
--------------------------------------------------------------------------
mercury-reviews mailing list
post:  mercury-reviews at cs.mu.oz.au
administrative address: owner-mercury-reviews at cs.mu.oz.au
unsubscribe: Address: mercury-reviews-request at cs.mu.oz.au Message: unsubscribe
subscribe:   Address: mercury-reviews-request at cs.mu.oz.au Message: subscribe
--------------------------------------------------------------------------